Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boost with pin action #2376

Merged
merged 11 commits into from
Nov 22, 2024
Merged

Boost with pin action #2376

merged 11 commits into from
Nov 22, 2024

Conversation

kumarpalsinh25
Copy link
Contributor

@kumarpalsinh25 kumarpalsinh25 commented Nov 19, 2024

Now you can attached Pin as action item to Boost Slide.

Reference Video:

Pin.action.on.Boost.mov

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 41 lines in your changes missing coverage. Please review.

Project coverage is 27.34%. Comparing base (f5f45d5) to head (a2045dd).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
native/core/src/events/common/object_reference.rs 0.00% 26 Missing ⚠️
native/acter/src/api/common.rs 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2376      +/-   ##
==========================================
- Coverage   27.38%   27.34%   -0.04%     
==========================================
  Files         602      604       +2     
  Lines       41785    41888     +103     
==========================================
+ Hits        11443    11455      +12     
- Misses      30342    30433      +91     
Flag Coverage Δ
integration-test 36.88% <0.00%> (-0.09%) ⬇️
unittest 19.21% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@kumarpalsinh25 kumarpalsinh25 marked this pull request as ready for review November 21, 2024 11:08
@gnunicorn
Copy link
Contributor

Just from the first looks of it (not blocking the merge) I think we should add:

  1. some indicator on the embedded object informing about the object type , maybe an icon on the top left? It will become increasingly difficult to understand what kind of object that is with their custom icon and titles ...
  2. it clearly shows we need a search for the embedded-selectors ... if you have many pins (and also later, when we allow objects from other spaces), this is pretty hard to navigate without a search..

app/lib/common/widgets/pin/pin_selector_drawer.dart Outdated Show resolved Hide resolved
app/lib/features/news/pages/add_news_page.dart Outdated Show resolved Hide resolved
app/lib/features/news/pages/add_news_page.dart Outdated Show resolved Hide resolved
#[default]
Link,
Embed,
EmbedSubscribe,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is embedSubscribe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bitfriend can answer this.

@kumarpalsinh25 kumarpalsinh25 merged commit 912284c into main Nov 22, 2024
21 of 23 checks passed
@kumarpalsinh25 kumarpalsinh25 deleted the kumar/boost-with-pin-action branch November 22, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Recently Done
Development

Successfully merging this pull request may close these issues.

3 participants